Skip to content

fix: adjust validation function for instructions at customize form#972

Merged
smarcet merged 1 commit into
masterfrom
fix/customize-form-instruction-validation
Jun 11, 2026
Merged

fix: adjust validation function for instructions at customize form#972
smarcet merged 1 commit into
masterfrom
fix/customize-form-instruction-validation

Conversation

@tomrndom

@tomrndom tomrndom commented Jun 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

ref: https://app.clickup.com/t/86baayr5u

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Updated validation for the instructions field in sponsor forms to properly handle HTML content.

@tomrndom
fix: adjust validation function for instructions at customize form
1175857 
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet June 11, 2026 15:02
@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f6163a4-b47a-4e68-9521-c9dfaf34dbf4

📥 Commits

Reviewing files that changed from the base of the PR and between 569f1d7 and 1175857.

📒 Files selected for processing (1)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/customized-form/customized-form.js
📝 Walkthrough

Walkthrough

The customized sponsor form's instructions field validation is updated to use requiredHTMLValidation instead of requiredStringValidation(), with the corresponding import added from the yup utilities module.

Changes

Sponsor Form Validation

Layer / File(s) Summary
Instructions field HTML validation
src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/components/customized-form/customized-form.js		 The instructions field validator in the Formik schema is switched from requiredStringValidation() to requiredHTMLValidation(), and the helper is added to the utils/yup import list.

Estimated code review effort

🎯 1 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • fntechgit/summit-admin#775: Updates sponsor form field validation by switching the instructions validator from requiredStringValidation() to requiredHTMLValidation() using the utils/yup helper.
  • fntechgit/summit-admin#952: Adjusts Yup validation for HTML instructions form field in the sponsor forms area by modifying validation schema imports and field validators.
  • fntechgit/summit-admin#766: Changes validation for the sponsor forms instructions field by switching the customized-form schema to requiredHTMLValidation.

Suggested reviewers

  • smarcet

Poem

🐰 A form takes shape with HTML in mind,
Instructions validated, the right kind,
From strings to richness, the change is small,
But HTML-aware, it serves us all! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/customize-form-instruction-validation

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Comment @coderabbitai help to get the list of available commands and usage tips.

smarcet
smarcet approved these changes Jun 11, 2026
View reviewed changes

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit dadc5ed into master Jun 11, 2026
8 of 9 checks passed
smarcet pushed a commit that referenced this pull request Jun 11, 2026
@tomrndom @smarcet
fix: adjust validation function for instructions at customize form (#972
d962873 
)

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarcet smarcet smarcet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomrndom @smarcet